Dev/anasanc/pep addingcommonextensioncode#41
Merged
Conversation
jscalev
reviewed
Mar 11, 2026
| HashTypeSHA256 | ||
| ) | ||
|
|
||
| func ValidateValueInAllowlist(value string, allowlist []string) error { |
Contributor
There was a problem hiding this comment.
What I'm wondering is whether the search should be done case insensitive. That seems to make sense to me.
Also not a bad idea to trim the values.
jscalev
approved these changes
Mar 11, 2026
Contributor
jscalev
left a comment
jscalev
left a comment
There was a problem hiding this comment.
Looks good overall. Had one small comment.
If you haven't done so already, I recommend asking AI if more unit tests are recommended (and to write them).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes here implement functions that will be frequently used across different extensions for a feature called Constrained Extensions. Constrained extensions limits the capabilities of onboarded extensions according to a customer-defined, pre-set policy.
The changes in this PR include: